Add demo-core command, log subcommand #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like another useful method for documenting the logging features. May prove a useful model for documenting module and command features in general, by providing an easy way to experiment with parameters on the command line.
|
Closes #57. |
Since there's now a `libexec/demo-core.d` directory, we have to be more deliberate about building the list of expected builtin commands.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #57 and #58, seems like another useful method for documenting the logging features. May prove a useful model for documenting module and command features in general, by providing an easy way to experiment with parameters on the command line.
Though I'm creating the PR with a working implementation, I still need to move
scripts/demotolibexec/demo-coreto make it a builtin. That way, the hope would be that framework users will discover and reproduce the./go demofunctionality in their own plugins and applications.I also still need to add tests. All of this will be done before merging.