Skip to content

Commit

Permalink
End run-tests, publish-test-results actions early
Browse files Browse the repository at this point in the history
The publish-test-results GitHub Actions workflow would keep running even
if it failed to download artifacts. run-tests would try to post coverage
even if tests failed, when there was no coverage/lcov.info to send.

This change now prevents both of those steps from taking place if an
earlier step failed.
  • Loading branch information
mbland committed Dec 29, 2023
1 parent f0a06e1 commit e2bf36f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/publish-test-results.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:

- name: Post test report
uses: dorny/test-reporter@v1
if: always()
with:
name: Test Results
path: 'TESTS-TestSuites.xml'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/run-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,5 @@ jobs:

- name: Send test coverage to Coveralls.io
uses: coverallsapp/github-action@v2
if: always()
with:
file: 'coverage/lcov.info'

0 comments on commit e2bf36f

Please sign in to comment.