Tweak stripJsonComments, add README license info #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stripJsonComments() tweak reorders the inComment conditional expressions to check curChar before the inComment value. This should save unnecessary inComment comparisons, while we always have to check curChar. Also added copyright and license info to README.md. Not strictly necessary, but still nice to have. Makes the project look and feel more professional to me, too. Made a few other typographic improvements to README.md as well.
mbland
force-pushed
the
strip-json-tweak-readme-copyright-license
branch
from
f63c05e
to
1d0f8a0
Compare
Pull Request Test Coverage Report for Build 7365592200
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stripJsonComments() tweak reorders the inComment conditional expressions to check curChar before the inComment value. This should save unnecessary inComment comparisons, while we always have to check curChar.
Also added copyright and license info to README.md. Not strictly necessary, but still nice to have. Makes the project look and feel more professional to me, too.
Made a few other typographic improvements to README.md as well.