Bump to 1.0.4, fix escaped whitespace before " bug #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, an escaped whitespace before the closing double quote character of a string would cause stripJsonComments() to see the double quote as escaped. This would throw off the comment removal algorithm since the string would still appear open. Escaped whitespace inside a string will cause a JSON parse error, but that shouldn't prevent stripJsonComments() from removing comments from otherwise legitimate JSON. The new test reproduced the error and verified the fix, which was to check the `inString` case before the whitespace-preserving cases.
Pull Request Test Coverage Report for Build 7387720627
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, an escaped whitespace before the closing double quote character of a string would cause stripJsonComments() to see the double quote as escaped. This would throw off the comment removal algorithm since the string would still appear open.
Escaped whitespace inside a string will cause a JSON parse error, but that shouldn't prevent stripJsonComments() from removing comments from otherwise legitimate JSON.
The new test reproduced the error and verified the fix, which was to check the
inStringcase before the whitespace-preserving cases.