Replace PATH_KEY with pathKey(), delete fixtureEnv #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original motivation was the loss of branch coverage from the PATH_KEY initialization expression only ever following one branch. But it also made the getPath.test.js tests more self-documenting. The same goes for hoisting the logic of the former fixtureEnv() helper into the getPath test fixture itself. Also, today I learned two things: 1. Forward slashes are legal Windows path separators, per: https://stackoverflow.com/a/63251716 2. Node's path.join() will convert any forward slashes in any of its arguments to backslashes on Windows: ```pwsh > node -e "console.log(path.join('foo/bar\baz/quux', 'xyzzy/plugh'))" foo\baaz\quux\xyzzy\plugh ``` Hence the replacement of path.join(...) with plain 'usr/local/bin', etc.
On Windows, the "rejects when command isn't found" case failed because the message contained "nonexistent.CMD" instead of plain "nonexistent". In the process of fixing it, I decided to add the makeEnv() test helper to make the test cases a little more concise and readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original motivation was the loss of branch coverage from the PATH_KEY initialization expression only ever following one branch. But it also made the getPath.test.js tests more self-documenting.
The same goes for hoisting the logic of the former fixtureEnv() helper into the getPath test fixture itself. Also, today I learned two things:
Forward slashes are legal Windows path separators, per: https://stackoverflow.com/a/63251716
Node's path.join() will convert any forward slashes in any of its arguments to backslashes on Windows:
Hence the replacement of path.join(...) with plain 'usr/local/bin', etc.