Final PluginImpl.compile() tests, custom matchers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PluginImpl.compile() is now 100% covered, as is the whole package, with these tests for partial imports, partial registration, and related options. Added custom Vitest expect matchers, toStartWith and toEndWith. I may want to package these at some point, though I'm not sure. - https://vitest.dev/guide/extending-matchers.html --- Though the code's 100% covered by small-to-medium tests, I do want to add an integration test to ensure the generated code loads correctly. (test/main.test.js is the medium-ish test.) I've effectively done that already in the strcalc/src/main/frontend tests from mbland/tomcat-servlet-testing-example. I just need to port some of the work I did there over here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PluginImpl.compile() is now 100% covered, as is the whole package, with these tests for partial imports, partial registration, and related options.
Added custom Vitest expect matchers, toStartWith and toEndWith. I may want to package these at some point, though I'm not sure.
Though the code's 100% covered by small-to-medium tests, I do want to add an integration test to ensure the generated code loads correctly. (test/main.test.js is the medium-ish test.) I've effectively done that already in the strcalc/src/main/frontend tests from mbland/tomcat-servlet-testing-example. I just need to port some of the work I did there over here.