Undo import(module).start() convention #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts part of commit 6ae34c2. After further consideration, I realized that the .start() convention didn't really provide much use. I was thinking it would encourage thinking of window and document as arguments injected into the module. However, modules can be designed that way and tested directly without this idiom. I did, however, take the liberty to filter out any <script type="module"> elements without a `src` attribute, for safety's sake.
mbland
added a commit
that referenced
this pull request
Dec 15, 2023
After thinking about it, it doesn't make sense to instantiate a component object with on internal state to invoke what could be a static method. If a componenent needed to create a stateful object to manage interactions, its static init() could take care of that. Also removes the start() function from main.js, which should've been removed in commit 366d9bc from #41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of commit 6ae34c2.
After further consideration, I realized that the .start() convention didn't really provide much use. I was thinking it would encourage thinking of window and document as arguments injected into the module. However, modules can be designed that way and tested directly without this idiom.
I did, however, take the liberty to filter out any <script type="module"> elements without a
srcattribute, for safety's sake.