Return DocumentFragment from Handlebars plugin #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More accurately, return a DocumentFragment from each template function generated by the Handlebars plugin:
Individual elements within the DocumentFragment can be accessed via its
.children
property. Passing the DocumentFragment to appendChild() will append all of its elements at once, detaching them from the fragment.I'm hoping returning the DocumentFragment will eventually help me solve a problem with testing <form> elements attached to DocumentFragments. Some of this weirdness is currently documented in a comment inside the "Request > postForm > succeeds" test in:
On top of that, in the branch in which I'm developing the new Calculator component, I'm submitting the form via HTMLFormElement.requestSubmit(). This works in jsdom, but not in Chrome or Firefox. I'm wondering if the problem is related, and if having the <form> attached to a DocumentFragment is to blame.