Pass the <div id="app"> to initApp() #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now main.js retrieves the top level element and passes it to initApp(),
which then gets passed to the other components.
---
While still thinking about the <form> + DocumentFragment problem, it
occurred to me that not every component should need to call
document.querySelector('#app'). I'm also currently expecting the <form>
solution I come up with to require creating elements on the main DOM
instead of a DocumentFragment.
Plus, if we ever want to change that ID, or use a class name, etc., we'd
have to update every querySelector() call. This new architecture
eliminates that particular problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now main.js retrieves the top level element and passes it to initApp(), which then gets passed to the other components.
While still thinking about the <form> + DocumentFragment problem, it occurred to me that not every component should need to call document.querySelector('#app'). I'm also currently expecting the <form> solution I come up with to require creating elements on the main DOM instead of a DocumentFragment.
Plus, if we ever want to change that ID, or use a class name, etc., we'd have to update every querySelector() call. This new architecture eliminates that particular problem.