Fix incorrect form.action due to incorrect base #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the base URL '/strcalc', resolving the form action URL './add' against document.location.href produces the path '/add', which is incorrect. With the base URL '/strcalc/', resolving './add' produces '/strcalc/add' as expected. --- Writing a test for this directly is difficult. (At least, it is at the component level using Vitest; an end-to-end Selenium test would catch it.) Tying the form action URL to a specific absolute path would render the component and its tests brittle. Also, it seems that trying to import the config from vite.config.js into a test (to access the config.base value) breaks the Vitest loader somehow. As a proxy for a test assertion, the PageLoader constructor now enforces that the base path ends with '/' (before it enforced that it _didn't_).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the base URL '/strcalc', resolving the form action URL './add' against document.location.href produces the path '/add', which is incorrect.
With the base URL '/strcalc/', resolving './add' produces '/strcalc/add' as expected.
Writing a test for this directly is difficult. (At least, it is at the component level using Vitest; an end-to-end Selenium test would catch it.) Tying the form action URL to a specific absolute path would render the component and its tests brittle. Also, it seems that trying to import the config from vite.config.js into a test (to access the config.base value) breaks the Vitest loader somehow.
As a proxy for a test assertion, the PageLoader constructor now enforces that the base path ends with '/' (before it enforced that it didn't).