Add jsdoc-cli-wrapper.js #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pure Node.js implementation of the original bin/jsdoc Bash shell wrapper. It's more robust and more portable, including to Windows. My next move is to extract this into its own published npm package.
For one thing, Windows can't interpret the `#!/usr/bin/env node` header, nor can it grok the `bin/jsdoc-cli-wrapper.js` path directly. Prefixing the script with `node` fixes the second problem. Updating getPath() to detect the 'win32' platform and adding the .CMD extension to the candidate path fixes the first. This is because 'pnpm install' will create a CMD.EXE wrapper for the installed script on Windows.
Don't want to drag down the coverage percentage for the main application. But I am about to break both jsdoc-cli-wrapper.js and rollup-plugin-handlebars-precompile into their own npm packages very soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure Node.js implementation of the original bin/jsdoc Bash shell wrapper. It's more robust and more portable, including to Windows.
My next move is to extract this into its own published npm package.