Try refining Run Tests GitHub Action again #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #7 triggered the Run Tests action again, but did so multiple times. I want all pushes to `main` to trigger builds, as well as updates to pull requests, but not pushes to other branches. And I want each action to run only once per PR. This is an attempt to get the right thing to happen based on advice from: - https://stackoverflow.com/a/65096459 - https://github.com/orgs/community/discussions/26276#discussioncomment-3251140
|
This change causes Run Tests to ignore paths starting with |
mbland
added a commit
that referenced
this pull request
Nov 26, 2023
The Run Tests `if:` conditional from #8 didn't allow #9 to run, because it excluded still opened pull requests. So now it should run: - On 'push' events on `main` - On any events from open 'pull_request' against `main` (specifically opened, synchronize, and reopened) - On any closed 'pull_request' event resulting in a merge into `main` I also realized that including the "edited" action type didn't actually make a lot of sense for my purposes. For reference: - https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request - https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7 triggered the Run Tests action again, but did so multiple times.
I want all pushes to
mainto trigger builds, as well as updates to pull requests, but not pushes to other branches. And I want each action to run only once per PR.This is an attempt to get the right thing to happen based on advice from: