Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode tag dublicates #40

Closed
yury opened this issue Feb 24, 2010 · 2 comments
Closed

unicode tag dublicates #40

yury opened this issue Feb 24, 2010 · 2 comments

Comments

@yury
Copy link
Contributor

yury commented Feb 24, 2010

new_tag_names = list.reject { |name| existing_tags.any? { |tag| tag.name.downcase == name.downcase } }

code above work incorrectly with unicode tag names. Names should be downcased with mb_chars.downcase

here is the patch:
http://github.com/yury/acts-as-taggable-on/commit/31385691e989e2b15ddab1d318d673f4cb69ef4e
Can't write test to reproduce problem, because sqlite LIKE is case sensitive with unicode chars.

@eet-nu
Copy link

eet-nu commented Mar 8, 2010

I was unable to pull your commit for some reason, so I've changed the code myself. Thanks for the patch!

@yury
Copy link
Contributor Author

yury commented Mar 8, 2010

Cool, thanks

kuahyeow pushed a commit to kuahyeow/acts-as-taggable-on that referenced this issue Mar 28, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant