Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*** NoMethodError Exception: undefined method `set_attribute_was' for #955

Open
raviy06 opened this issue May 8, 2019 · 6 comments · Fixed by sin-to-jin/acts-as-taggable-on#1
Open

*** NoMethodError Exception: undefined method `set_attribute_was' for #955

raviy06 opened this issue May 8, 2019 · 6 comments · Fixed by sin-to-jin/acts-as-taggable-on#1

Comments

@raviy06
Copy link

raviy06 commented May 8, 2019 •
edited
Loading

rails: 6.0.0.rc1
set_attribute_was method has been removed from ActiveModel. Now previous changes are being tracked by ActiveModel::AttributeMutationTracker, I think.
Anyways, I just commented the set_attribute_was in a forked branch to make it work. This might have some consequences not sure how severe.

Do you want me to raise that request? or do you have any other suggestion as to How to handle this?

Please let me know, I'll be glad to help out.
@kangguru
Copy link

kangguru commented May 9, 2019

tried to understand how to recreate the old behavior with the new mutation tracker .... so far no luck :(

when the line in question is removed you won't see the actual change when using changes on the dirty object, it will always assume that the original value is nil

@raviy06
Copy link
Author

raviy06 commented May 9, 2019 •
edited
Loading

From what I could gather they have changed the implementation of changes.
See:
https://github.com/rails/rails/blob/5-2-stable/activemodel/lib/active_model/dirty.rb#L234
and
https://github.com/rails/rails/blob/6-0-stable/activemodel/lib/active_model/dirty.rb#L217

@wildjcrt
Copy link

wildjcrt commented May 13, 2019 •
edited
Loading

#set_attribute_was was removed in this PR rails/rails#35933

@stefankp
Copy link

Are there plans to fix this?

TurtleTony added a commit to TurtleTony/rails-image-board that referenced this issue Jul 9, 2019
@TurtleTony
Update all gems to most recent version
32731dd 
This is partially also preparation for Rails 6. However the upgrade can
only be made once acts_as_taggable_on fixes #955
mbleigh/acts-as-taggable-on#955

Signed-off-by: Tristan <tristan.schoenhals@gmail.com>
@TurtleTony TurtleTony mentioned this issue Jul 10, 2019
Open
TheRealNeil added a commit to TheRealNeil/acts-as-taggable-on that referenced this issue Aug 7, 2019
@TheRealNeil
Update for Rails 6.0.0.rc2 - undefined method `set_attribute_was'
5458d64 
mbleigh#955
sin-to-jin pushed a commit to sin-to-jin/acts-as-taggable-on that referenced this issue Aug 19, 2019
When Rails version is 6.0.0, skip this.
aa602f3 
To fix mbleigh#955
When the Rails version is 6.0.0, it becomes true, so I want to skip set_attribute_was.
@sin-to-jin sin-to-jin mentioned this issue Aug 19, 2019
Merged
champierre added a commit to HoloeyesInc/acts-as-taggable-on that referenced this issue Sep 2, 2019
@champierre
set_attribute_was is deprecated in Rails 6, so skipped it.
d6d0a3e 
Ref. mbleigh#955
@mkilling mkilling mentioned this issue Sep 19, 2019
Merged
@designcrumble
Copy link

Any updates on this?
I can attach tags to different models but the tag_list always appear to be nil.
When I do @model.tag_list , I can see the tags!

Thanks ❤️

@wildjcrt
Copy link

I tested and found #968 solved this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When Rails version is 6.0.0, skip this. sin-to-jin/acts-as-taggable-on
5 participants
@kangguru @wildjcrt @stefankp @designcrumble @raviy06