Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix seed-fu for postgresql when there is no primary key defined #53

Merged
merged 2 commits into from Jun 16, 2014

Conversation

aserafin
Copy link
Collaborator

This is a fix for seed-fu and postgresql that handles two cases:

  • when there is no primary key defined on table
  • when there is primary key defined but no with serial type (so no sequence is created)

Also changed deprecated rspec syntax and fix attr_protected attribute in model SeededModel that breaks test suite

Hope you will find this useful and merge it soon.

@@ -6,3 +6,5 @@ Gemfile.lock
.bundle
.yardoc
doc
.rvmrc
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add this to ur .gitignore_global 😃

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, will do

@kbackowski
Copy link

👍 on this. I've also run into this issue.

@george
Copy link
Contributor

george commented Feb 12, 2014

👍

@dvdplm
Copy link

dvdplm commented Apr 8, 2014

Also affected. +1

aserafin added a commit that referenced this pull request Jun 16, 2014
fix seed-fu for postgresql when there is no primary key defined
@aserafin aserafin merged commit 2f63925 into mbleigh:master Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants