Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs randomly hidden from bottom of tree #118

Open
exscape opened this issue Jan 3, 2020 · 3 comments
Open

Tabs randomly hidden from bottom of tree #118

exscape opened this issue Jan 3, 2020 · 3 comments

Comments

@exscape
Copy link

exscape commented Jan 3, 2020

The past few days (probably since v4 or one of the point versions of it) I've been having a very annoying problem with Sidebery. All tabs below a certain tab in the list are invisible, i.e. not shown at all in Sidebery. I can still switch between them with ctrl+tab and ctrl+shift+tab, and they are still visible in the tab bar -- but I always have the tab bar hidden/disabled. I just re-enabled it to check the behavior for this bug report.

At the moment this is the case more often than not, so I'm navigating blindly (except for the older tabs above the "cut-off point").

Possibly related: A few of my (five) pinned tabs also behave strangely. They are all shown if I set "Pinned tabs position" to anything other than "panel", but with that setting, only three out of the five show up. The ones that always show are #3, #4 and #5.

After getting tired of this I backed up my profile and reset Sidebery entirely (from the settings page), which unfortunately didn't solve the issue.
Clearing storage solves it for a short while as Sidebery seems to reload the correct tab list, but even after a reset settings + clear it bugs out very shortly; just now it happened literally 10 seconds after reset. It usually takes less than a few minutes.

Also, after a reset, the pinned tabs are not visible in Sidebery at all. I have to change the position to top/left/right for them to appear.

Steps to reproduce

The pinned tabs seem to always be bugged with the "panel" setting, while the disappearing regular tabs issue seems intermittent; I have not figured out a way to reproduce except to simply add/remove tabs, rearrange the tree etc. until it happens.

Expected behavior

All pinned tabs visible regardless of "Pinned tabs position" setting, and no randomly hidden tabs in the regular tree.

Actual behavior

See above.

Environment info

OS: Windows 10 1903 (18362.535)
Firefox version: 72.0
Addon version: 4.0.4

These are from before the resets mentioned above:

{ "settings": { "version": "4.0.4", "nativeScrollbars": false, "stateStorage": "global", "ctxMenuNative": false, "autoHideCtxMenu": 250, "ctxMenuRenderInact": true, "navBarLayout": "horizontal", "navBarInline": true, "hideAddBtn": true, "hideSettingsBtn": false, "navBtnCount": false, "hideEmptyPanels": true, "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": false, "activateLastTabOnPanelSwitching": true, "skipEmptyPanels": false, "showTabRmBtn": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "moveNewTabPin": "none", "moveNewTabParent": "none", "moveNewTabParentActPanel": false, "moveNewTab": "none", "pinnedTabsPosition": "top", "pinnedTabsList": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "bookmarksPanel": false, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "xs", "bgNoise": false, "animations": false, "theme": "default", "style": "light", "sidebarCSS": false, "groupCSS": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "tabDoubleClick": "exp", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu" }, "permissions": { "allUrls": true, "tabHide": true, "actualAllUrls": true, "actualTabHide": true }, "storage": { "size": "46.2 kb", "props": { "containers_v4": "2 b", "cssVars": "1.6 kb", "favAutoCleanTime": "10 b", "favUrls": "334 b", "favicons": "35.3 kb", "panelIndex": "1 b", "panels_v4": "333 b", "prevTabsData_v4": "5.7 kb", "settings": "2 kb", "tabsData_v4": "687 b" } }, "panels": "TypeError: t is undefined", "cssVars": { "tabs_height": "23px", "tabs_font": "0.95rem sans-serif" }, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 74 } ], "bookmarks": { "bookmarksCount": 117, "foldersCount": 15, "separatorsCount": 1, "maxDepth": 4 } }
@mbnuqw
Copy link
Owner

mbnuqw commented Jan 4, 2020

Thanks for the report and sorry for these bugs.
I've just uploaded v4.0.5 with some fixes, could you try it?

@exscape
Copy link
Author

exscape commented Jan 4, 2020

Thanks! I just upgraded, and I'll report back if it bugs out (or in a few days if it doesn't).

On upgrade (and Firefox restart) it did nuke my tree. Not a huge issue as I can get it back in a minute or so, but there is one weird thing. The last few times it has reset (by me in the settings) and on upgrade just now, all of my group pages remain, except for one. So to restore my tree I select a bunch of tabs, drag them to their group, and repeat a few times, except for the one time where I need to create the group again. A bit odd that only most of them are saved.

@exscape
Copy link
Author

exscape commented Jan 4, 2020

Unfortunately it only worked for less than 20 minutes. :(

I think it worked better when I didn't use my userChrome modifications -- is it at all possible that they are linked, or is that just a total coincidence?

#TabsToolbar .tabbrowser-tab { display: none !important; /* opacity: 0.01 !important; */ }

With the opacity line, it seemed to work all day (with 4.0.4), so I switched back to display: none.

Edit: A few days later the above still holds true. It has never failed with opacity set, but with display: none it seems to fail rather quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants