Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

th-lift's instance for Lift (Ratio a) is too narrow #14

Closed
RyanGlScott opened this issue Feb 21, 2015 · 1 comment
Closed

th-lift's instance for Lift (Ratio a) is too narrow #14

RyanGlScott opened this issue Feb 21, 2015 · 1 comment

Comments

@RyanGlScott
Copy link
Owner

template-haskell-2.10.0.0 introduces an instance for Lift (Ratio a):

instance Integral a => Lift (Ratio a) where
    lift x = return (LitE (RationalL (toRational x)))

However, th-lift currently defines an instance only for Lift Rational, which means th-lift users with older versions of template-haskell cannot take advantage of the more general instance. Can you change the implementation in th-lift to match template-haskell-2.10.0.0?
@mboes mboes closed this as completed in 6008441 Feb 22, 2015
@mboes
Copy link
Collaborator

mboes commented Feb 22, 2015

New release uploaded to Hackage. Thanks!

@RyanGlScott RyanGlScott mentioned this issue Feb 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mboes @RyanGlScott