Skip to content
This repository has been archived by the owner on Feb 3, 2024. It is now read-only.

The pypi version is not same as the github version (0.9.27), has "we have " prompt under _0_init_tld.py #278

Closed
j0eii opened this issue Feb 13, 2023 · 7 comments

Comments

@j0eii
Copy link

j0eii commented Feb 13, 2023

Describe the bug

pypi version is not sync with github version.

To Reproduce

Steps to reproduce the behavior:
image
This is what i download from pypi https://pypi.org/project/whois/

Expected behavior

version not sync

Suggested mediation

update the pypi version and sync with github version

@maarten-boot
Copy link
Collaborator

yes confirmed,
when installing a fresh copy via pip install we do not get the same files as when we download the release:
( https://github.com/DannyCork/python-whois/archive/refs/tags/0.9.27.tar.gz )

@j0eii
Copy link
Author

j0eii commented Feb 22, 2023

temp fix:
use pipenv

[packages]
# replace whois= "*"
whois =  {git = "https://github.com/DannyCork/python-whois.git", editable = true, ref = "0.9.27"}

@falz
Copy link

falz commented Mar 29, 2023

to be explicit, for folks getting 'we have com' or 'we have net' messages when doing lookups, this is why.

@tjaartvdwalt
Copy link

This is present 0.9.27, 0.9.26 and 0.9.25.

It would be nice to have the latest version fixed in pip, since that is what most people will likely be downloading.

tjaartvdwalt added a commit to outsideopen/oo-bin-py that referenced this issue Apr 12, 2023
We pin the version of whois, because of this issue
mboot-github/python-whois#278
tjaartvdwalt added a commit to outsideopen/oo-bin-py that referenced this issue Apr 12, 2023
We pin the version of whois, because of this issue
mboot-github/python-whois#278
@maarten-boot
Copy link
Collaborator

i have no access to publish to pipy so i am currently waiting for a response from the owner of the git repo,
if none comes i will create a new clone and a new pipy entry so we can proceed with up-to date code, but with a new name ;-)

tjaartvdwalt added a commit to outsideopen/oo-bin-py that referenced this issue Apr 12, 2023
* Add dnsme script

We pin the version of whois, because of this issue
mboot-github/python-whois#278

* Sort mx records

* Install whois dependency, and error gracefully if not installed

* Sort all lookups
@maarten-boot
Copy link
Collaborator

FYI:

a new pypi library exists now at: https://pypi.org/project/whoisdomain/

it is a cleaned up copy of this repo, i switched to versioning from 1.x.y where x is YYYYMMDD and y starts from 1 in case we need more then one pypi upload per day

the whois directory is renamed to whoisdomain and the package is released as whoisdomain , currently the actual code is unchanged

code is maintained at: https://github.com/mboot-github/WhoisDomain

when importing as :

import whoisdomain as whois
the rest of your code can stay the same

@falz
Copy link

falz commented Apr 17, 2023

Thank you for this, just did some initial testing and working well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants