Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitInstructionsByColon: false doesn't work properly #22

Closed
kolnogorov opened this issue Dec 7, 2021 · 5 comments
Closed

splitInstructionsByColon: false doesn't work properly #22

kolnogorov opened this issue Dec 7, 2021 · 5 comments

Comments

@kolnogorov
Copy link
Contributor

kolnogorov commented Dec 7, 2021

I am the guy who writes many instruction in one line, separated by colon, so, i need to have splitInstructionsByColon set to false.

But eventually, when it's set to false, you just can't write space symbol after colon (because it's trimmed), so it's impossible to type more than one instruction in a line:

main.asm.-.aggregation.-.Visual.Studio.Code.Administrator.2021-12-07.15-46-36.mp4
@kolnogorov
Copy link
Contributor Author

kolnogorov commented Dec 7, 2021

I made a PR that fix it: #23

But really i am not sure, is it a proper bugfix or just a workaround.

mborik added a commit that referenced this issue Dec 9, 2021
@kolnogorov
Copy link
Contributor Author

kolnogorov commented Dec 10, 2021

Tested it in a last few days and found some bugs with inserting tabs and spaces before line if it begins with label.
I am not sure, if it was affected by my fix or it was beforehand, so i will test it more deeply and report the results.

mborik added a commit that referenced this issue Dec 12, 2021
- huge refactor of formatter and completion
@mborik
Copy link
Owner

mborik commented Dec 12, 2021

@kolnogorov I've done some massive refactor to improve experience while on-type formatting and completion.
Multi-instruction behaviour on line was tested to work pretty well. I hope that will be much better.

@kolnogorov
Copy link
Contributor Author

@mborik so it will be in the next version, and this issue can be closed? :)

@mborik
Copy link
Owner

mborik commented Dec 18, 2021

Closing by releasing of v0.7.8

@mborik mborik closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants