Skip to content

Commit

Permalink
Fix race condition in transition tests.
Browse files Browse the repository at this point in the history
The transition-test-text callback was failing to fire when using the
latest Node.js master (82bcdbb8aaa4cf58917dc8d3fd4fcfc272512a2c).  This
was most likely due to these tests being run in a different order due to
a different object enumeration order.
  • Loading branch information
jasondavies committed May 27, 2012
1 parent dd2a424 commit 8205128
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions test/core/transition-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,32 +34,36 @@ suite.export(module);

var suite = vows.describe("transition");

// Subtransitions
suite.addBatch({

// Subtransitions
"select": require("./transition-test-select"),
"selectAll": require("./transition-test-selectAll"),
"transition": require("./transition-test-transition"),
});

// Content
// Content
suite.addBatch({
"attr": require("./transition-test-attr"),
"attrTween": require("./transition-test-attrTween"),
"style": require("./transition-test-style"),
"styleTween": require("./transition-test-styleTween"),
"text": require("./transition-test-text"),
"remove": require("./transition-test-remove"),
});

// Animation
// Animation
suite.addBatch({
"delay": require("./transition-test-delay"),
"duration": require("./transition-test-duration"),
});

// Control
// Control
suite.addBatch({
"each": require("./transition-test-each"),
"call": require("./transition-test-call"),
"tween": require("./transition-test-tween"),
"id": require("./transition-test-id"),
"time": require("./transition-test-time")

});

suite.export(module);

0 comments on commit 8205128

Please sign in to comment.