Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler no-global for CommonJS. #2228

Closed
wants to merge 1 commit into from
Closed

Simpler no-global for CommonJS. #2228

wants to merge 1 commit into from

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Feb 8, 2015

We don’t need the index.js to unset the global if we don’t set it.

We don’t need the index.js to unset the global if we don’t set it.
@mbostock mbostock added this to the 3.5.x milestone Feb 8, 2015
@mbostock mbostock added the code label Oct 22, 2015
@mbostock mbostock modified the milestones: 3.5.7, 3.5.x Oct 22, 2015
@mbostock mbostock closed this Oct 22, 2015
@mbostock mbostock deleted the simpler-global branch October 22, 2015 20:35
@mbostock
Copy link
Member Author

Merged into #2591.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants