Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

Commit

Permalink
Treemap layout now uses properties.
Browse files Browse the repository at this point in the history
The inset property has been replaced by the standard top, right, bottom and left
properties; see the earlier commit that adds a convenience margin function to
mark. This commit also changes Treemap to use the standard pv.dom node
representation.

I also removed the magic to hide internal nodes if an inset (margin) is used;
it's probably better if users get in the habit of defining a visible function
to show only leaf nodes instead, e.g., visible(function(d) !d.firstChild).
  • Loading branch information
Mike Bostock committed Mar 12, 2010
1 parent 64a7fc5 commit cdc58b5
Show file tree
Hide file tree
Showing 4 changed files with 151 additions and 239 deletions.
4 changes: 1 addition & 3 deletions TODO
Expand Up @@ -7,16 +7,14 @@ data/Scale.js
layout/Layout.js
- allow interactive expanding / collapsing of tree nodes?
- migrate all implementations to extend pv.Layout
- use private data, or at least standardize which attributes are populated

layout/Tree.js
- allow depth and breadth offset to be computed automatically

layout/{Cluster,Partition}.js
- support customized inner/outer radius

layout/Treemap.js
- use pv.Dom.Node

mark/Mark.js
- antialias doesn't always work as expected; requires pixel rounding?
- events property: "ignore", "all", "visible"
Expand Down

0 comments on commit cdc58b5

Please sign in to comment.