Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternator 0.8.0-SNAPSHOT: Revise for version 1.6.11 of AWS SDK for Java. #84

Merged
merged 1 commit into from
Jan 3, 2014

Conversation

rrutt
Copy link
Contributor

@rrutt rrutt commented Jan 3, 2014

This addresses Issue #83 regarding use of version 1.6.8 or higher of the AWS SDK for Java:

#83

The primary fix was to modify AlternatorDBClient.setEndpoint to explicitly pass "dynamodb" as the service name to the superclass to bypass new inference logic based on the class name of the client. The same revision was also made to AlternatorDBClientV2.setEndpoint.

super.setEndpoint(endpoint, "dynamodb", null);

Also, the .invoke method in both client classes was revised to unwrap the Response object now returned by the AmazonHttpClient.execute method. (Version 1.6.4 simply returned an object of type X.)

Response<X> result = client.execute(request, responseHandler, errorResponseHandler, executionContext);
return result.getAwsResponse();

All tests pass using 'mvn verify', including an alternate run with AlternatorTest.SPAWN_LOCAL_DB_SERVICE temporarily compiled as false, with an instance of Alternator running in another terminal window via 'mvn exec:java'.

I updated the maven-compiler-plugin version to 3.1 to resolve an issue with setting the <source> and <target> to Java 1.5 to match the AWS SDK for Java settings.

I updated the snapshot version of Alternator to 0.8.0 since this involves referencing a new version of the AWS SDK for Java for client projects.

The AWS SDK for Java source code can be reviewed at their GitHub repository:

https://github.com/aws/aws-sdk-java.git

mboudreau added a commit that referenced this pull request Jan 3, 2014
Alternator 0.8.0-SNAPSHOT: Revise for version 1.6.11 of AWS SDK for Java.
@mboudreau mboudreau merged commit c6186ad into mboudreau:master Jan 3, 2014
@mboudreau
Copy link
Owner

You're awesome Rick :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants