Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append items to navbar #14

Closed
Qumeric opened this issue Jul 2, 2016 · 1 comment
Closed

Append items to navbar #14

Qumeric opened this issue Jul 2, 2016 · 1 comment

Comments

@Qumeric
Copy link
Contributor

Qumeric commented Jul 2, 2016

As "Getting Started" page says:

Items are added by simply passing them to the Navbar-constructor. This is purely convenience, instead it is possible to append to the items attribute of topbar as well.

I have tried to append to the items attribute and failed. Eventually I figured out that this attribute is a tuple so it's impossible to append.
I have found a simple workaround

navbar = Navbar('', ...)
navbar.items = list(navbar.items)

but it doesn't seem like a proper way to do things. Shouldn't Navbar.items be a list instance by default?

@mbr
Copy link
Owner

mbr commented Jul 3, 2016

That's a valid point and either the documentation or the implementation need to change here.

@mbr mbr closed this as completed in f9d2569 Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants