Be resilient against parallel directory creations. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures in Travis are unrelated (minio does not start) |
|
Fixed the problem with minio on master. |
xhochy
force-pushed
the
ensure-thread-safety-makedirs
branch
from
fe5d0c2
to
54f7e05
Compare
|
Rebased and Travis is happy. The decrease in coverage seems to be down to the Azure tests being skipped, this should be irrelevant for this branch. |
xhochy
force-pushed
the
ensure-thread-safety-makedirs
branch
from
a8d2584
to
098daec
Compare
fmarczin
approved these changes
Jul 3, 2018
criemen
requested changes
Jul 4, 2018
When using multiprocessing, simultaneous writes can lead to the situation where both code paths first check if the directory exists and create it in the negative case. As check and creation aren't a single atomic operation, one of them might fail.
xhochy
force-pushed
the
ensure-thread-safety-makedirs
branch
from
839292d
to
3d9f53d
Compare
|
Rebased and added changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiprocessing, simultaneous writes can lead to the
situation where both code paths first check if the directory exists and
create it in the negative case. As check and creation aren't a single
atomic operation, one of them might fail.