Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seek should return the current position #79

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Seek should return the current position #79

merged 2 commits into from
Jul 11, 2018

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Jul 11, 2018

Found while wrapping this in a io.BufferedRandom.

@fmarczin fmarczin self-requested a review July 11, 2018 09:39
@coveralls
Copy link

coveralls commented Jul 11, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-8.3%) to 81.108% when pulling edbb71b on xhochy:azurestore-seek-return-tell into 392abb4 on mbr:master.

fmarczin
fmarczin approved these changes Jul 11, 2018
View reviewed changes
Copy link
Collaborator

@fmarczin fmarczin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We don't document what exactly the return value of open() implements, but this makes the Azure backend more complete and brings it more in line with the other backends.

@fmarczin fmarczin merged commit 32c83b3 into mbr:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarczin fmarczin fmarczin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xhochy @coveralls @fmarczin