Cancel the pending image requests #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the component gets unmounted the pending request should also get canceled
Anenth
force-pushed
the
fix-cancel-pending-image
branch
from
d80eb46
to
588caf7
Compare
|
When the component is unmounted the |
|
@mbrevda, I gave that a try, but it was not canceling the pending request. |
|
My bad - was on mobile and didn't realize this was a PR. Thanks so much for pointing this out! For the record, I have confirmed that the current behavior of deleting the prompt does not cancel the current download. |
|
@mbrevda Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the component gets unmounted the pending request should also get canceled
Before
After
