Support bin 16 and bin 32 types and decode bin as str #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting *decode-bin-as-string* to T bin 8, bin 16 and bin 32 types will be decoded as strings.
|
Hi Andrej, looks good to me. Regarding bin as strings I'd like to tell you about phmarek/neovim@5a91c7e and the discussion at neovim/neovim#1758 (if you're interested) - so I'll accept that as well ;) Would you please prepare one more patch with a few lines of tests? Thanks a lot! |
|
Ah, very nice to know you were involved, makes this a lot easier :) . In any case, I added some basic tests, hope they are OK. To be completely honest though, it bothers me a bit that while the package with this patch now supports decoding of bin format, it doesn't support encoding it as far as I can tell? |
phmarek
added a commit
that referenced
this pull request
Aug 13, 2015
Support bin 16 and bin 32 types and decode bin as str
|
Thanks a lot! Well, it doesn't bother me. If we ever find out that we need the same feature for encoding, we can still add it. |
|
Fair enough 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would submit this as 2 separate pull requests, but I cannot figure out how to do that at all. In any case, first commit adds support for decoding 0xc5 (bin 16) and 0xc6 (bin 32) as per msgpack spec.
Second commit is IMHO a bit controversial. It adds decode-bin-as-string which, when set to T, tells the decoder to read binary arrays as strings. This is useful because some programs (namely neovim), due to supporting various encodings on their side of things, send strings using this type.
On one hand by default this commit doesn't really affect users that don't want/expect this behavior, but on the other hand it can easily be argued that interpreting bin as str is not really the work of cl-messagepack. I'll leave the decision up to you.