Misc cleanup #10
Open
Misc cleanup #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`buffer-name` isn't documented anywhere in the Emacs docs and doesn't seem to have any effect. Remove it.
`special-mode` provides some nice default handling for viewing data (as opposed to editing files), e.g. single-key navigation.
Ruby is great and all, but not universally installed. Rewrite the wrapper in plain ol' shell to make it more portable. This also changes the behavior of `emacs-pager` slightly in that it invokes Emacs if it's not already running by using the `emacsclient` `-a` switch with an empty string argument.
It would be nice to page files specified at the command line a la less,
e.g.:
$ emacs-pager my-cool-file.txt
Add support for this by detecting if any command line args are specified.
If any are specified they're assumed to be files that we will page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few fixes and cleanups:
special-mode, which exists for just this sort of thing, rather than the more bare-bonesfundamental-mode.