emacs-pager: replace insecure Ruby script with sh version #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use mktemp to create a unique and secure temporary file; avoid clobbering an existing file if the same command is run in parallel sessions, and avoid creating a temporary file with insecure permissions and/or a predictable name. Also, use shell traps to clean up properly even if interrupted.
|
I also did something similar tonight at PR #6, but used Python and "with tempfile as f ...". The shell version only traps a subset of all possible signals, but the Python "with .. as f" means that any signal causes the temp file to go out of scope and get deleted: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mktemp to create a unique and secure temporary file; avoid clobbering
an existing file if the same command is run in parallel sessions, and
avoid creating a temporary file with insecure permissions and/or a
predictable name.
Also, use shell traps to clean up properly even if interrupted.