Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code of another article #34

Closed
Iqun1314 opened this issue Oct 23, 2019 · 14 comments
Closed

The code of another article #34

Iqun1314 opened this issue Oct 23, 2019 · 14 comments

Comments

@Iqun1314
Copy link

Hi,

First thanks for your great work and open source.

I have downloaded your code and run it on my laptop, the result is really cool. But I notice your another article "RINS-W: Robust Inertial Navigation System on Wheels" , I have not found the code.
So, if you can upload the code of the article "RINS-W: Robust Inertial Navigation System on Wheels", I will be deeply grateful .

Thank you very much.

@last-one
Copy link

@Iqun1314 Hi, I am re-implementing RINS-W. Do you download the urban dataset and generate the ground-truth of RINS-W? I don't know how to generate the ground-truth of RINS-W by author. But according to my understanding of this article, the statistics I get are very different from the reported by the author. So, I hope to be able to communicate if you are re-implementing RINS-W.

@Iqun1314
Copy link
Author

Ok,I will.
I had implemented another article https://arxiv.org/abs/1904.06064
The urban dataset is contained in the ZIP.
But I don't know how the author extract the dataset from the KITTI dataset.

@mbrossar
Copy link
Owner

This is the paper of this repo. The code to extract the dataset is based on pyKitti.

Regarding the coe of RINS-W, we expect to put it online soonely :)

@Iqun1314
Copy link
Author

This is the paper of this repo. The code to extract the dataset is based on pyKitti.

Regarding the coe of RINS-W, we expect to put it online soonely :)

Thank you for your reply. I'm looking forword to the code of RINS-W.

@lijiyao111
Copy link

lijiyao111 commented Aug 5, 2020

@mbrossar Hi Martin, I am also very curious to know the details of the implementation of the RINS-W paper. The odometry performance is really good of RINS-W. Following up on the same ask since I saw your reply in March, do you plan to release the code soon in the near future? If so, roughly about when should we expect?

@mbrossar
Copy link
Owner

mbrossar commented Aug 6, 2020

I have put the code here, thank you for recalling me. There are few improvement with the paper, e.g. using CNN rather than LSTM, I let you see.

@lijiyao111
Copy link

@mbrossar Oh, thanks for such a prompt response! That was much quicker than I was expecting. Also thanks for uploading the code!
Just two quick questions:
In your paper it's using LSTM and in the code I see it's CNN. So you mean that the LSTM network has better performance than CNN?

I see you create the other repo yesterday/today. Seems that the code in that repo is not complete. In one file I see

from src.utils import pload, pdump, yload, ydump, mkdir, bmv
from src.utils import bmtm, bmtv, bmmt, pltt, plts, axat, pltt, plts
from src.lie_algebra import SO3, CPUSO3
from src.iekf import RecorderIEKF as IEKF

While lie_algebra.py file is there, I did not find iekf.py and utils.py files in the repo. Just to confirm with you.

@mbrossar
Copy link
Owner

mbrossar commented Aug 7, 2020

No, it is the opposite, I mean that CNN network has better performance than LSTM.
I am currently updated the second repo, you can now find iekf.py and utils.py files.

@lijiyao111
Copy link

@mbrossar now I can see all the files, thanks!

Maybe "performance" was not the right word I should use. In the README file, you said the CNN is faster to train than LSTM. I am curious if LSTM has better prediction accuracy than CNN. Could you comment on that from the validation test you did?

@mbrossar
Copy link
Owner

I obtained better prediction accuracy with the CNN along with better time execution.

In the readme, I indicate CNN is faster to train than LSTM, which is in fact true. As performance of LSTM and CNN depends on hyperparameter, I can just say that, on my experiments, CNN were better.

@scott81321
Copy link

Can you confirm if Brossard's code on:

https://github.com/mbrossar/RINS-W

has the python tools by which to convert a dataset in KITTI format into Brossard's
particular python pickle format ready to be injected into his program in ai-imu-dr ?

@JzHuai0108
Copy link

@Iqun1314 From your posts, I think you had access to the training data and the trained model.
Could you please share it with us?

Apparently, many followers of AI-IMU DR including the author Martin are looking for these data and model.
You may upload it to a cloud service provider like google drive or baidu cloud, and share the link with us.
Thank you so much.

@scott81321
Copy link

I found out that Brossard's code has the means to transform KITTI files into Brossard's pickle files which are composed of 5 python dictionaries apart from time. It is within main_kitty.py. Now his pickle file data dictionaries are made of u (accel+gyro), and quantities like p_gt which depend on lat/lon , v_gt is velocity Rot_gt are rotation matrices depending on roll, pitch and yaw. These are indexed and synchronized with the timestamp dictionary 't'. What I don't know is how GPS outage is modeled. Brossard's original data could tell us that. How do you work a test case where you only have u? ie. u and no GPS? For KITTI files, the standard is to replace the last 3 integer numbers with -1, but Brossard's code ignores such numbers. Can anyone tell me out GPS outage is modeled insofar as the test pickle files are concerned?

@mbrossar
Copy link
Owner

Pickle files are now available at new url, please see the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants