Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #205

Merged
merged 3 commits into from Feb 26, 2021
Merged

Update README.md #205

merged 3 commits into from Feb 26, 2021

Conversation

mbround18
Copy link
Owner

@mbround18 mbround18 commented Feb 26, 2021

Description

Contributions

  • Added release notification discord.

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18 mbround18 added the documentation Changes only affect the documentation label Feb 26, 2021
@pwlgrzs
Copy link

pwlgrzs commented Feb 26, 2021

Small suggestion, I would remove docker-compose specific information, I'd guess not everyone (like me) is using compose to start this image. Simply new release - please refresh image would do I think. Thanks!

@mbround18
Copy link
Owner Author

mbround18 commented Feb 26, 2021

Small suggestion, I would remove docker-compose specific information, I'd guess not everyone (like me) is using compose to start this image. Simply new release - please refresh image would do I think. Thanks!

I dig it, I am updating the notification for discord to give access to changing the title as well so instead of seeing Broadcast it could be changed to the image id + version. This would also allow yall to update your webhook notification to have custom titles vs what was hard coded.

Created feature for the label updates #207

@mbround18 mbround18 changed the title Update README.md [WIP] Update README.md Feb 26, 2021
@mbround18 mbround18 changed the title [WIP] Update README.md [WIP]: Update README.md Feb 26, 2021
@mbround18 mbround18 changed the title [WIP]: Update README.md Update README.md Feb 26, 2021
@mbround18 mbround18 enabled auto-merge (squash) February 26, 2021 19:00
@mbround18 mbround18 merged commit 3e3f044 into main Feb 26, 2021
@mbround18 mbround18 deleted the mbround18/readme branch February 26, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants