Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #152

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Update README.md #152

merged 2 commits into from
Nov 15, 2020

Conversation

robhung
Copy link
Contributor

@robhung robhung commented Nov 14, 2020 •
edited

Copied from v1alpha2.md, seems was truncated when migrating.

mbrt
mbrt requested changes Nov 14, 2020
View reviewed changes
Copy link
Owner

@mbrt mbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. As we are at it, I would reword a bit to simplify the sentence.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@robhung @mbrt
Apply suggestions from code review
3285717 
Co-authored-by: Michele Bertasi <michele.bertasi@gmail.com>
@robhung robhung requested a review from mbrt November 15, 2020 12:12
mbrt
mbrt approved these changes Nov 15, 2020
View reviewed changes
Copy link
Owner

@mbrt mbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrt mbrt merged commit daa23e9 into mbrt:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrt mbrt mbrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robhung @mbrt