Move pkg to internal #210
Merged
Move pkg to internal #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make the interface between the cmd package and main clearer. There is now no mention of internal Gmail APIs in public interfaces and it should be possible to implement alternative init workflows without workarounds.
This is as easy as moving them from pkg/ to internal/.
mbrt
force-pushed
the
move-to-internal
branch
from
e138add
to
aaddb8e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all implementation details internal. This makes sure people don't start importing gmailctl packages and start depending on them.
To make this possible, the APIProvider interface used by
gmailctl/cmddoesn't mentionpkg/apianymore. The end result is much cleaner and should allow additional API providers to be added without too much effort.