Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent filter criteria #239

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Indent filter criteria #239

merged 1 commit into from
Apr 4, 2022

Conversation

lutzky
Copy link
Contributor

@lutzky lutzky commented Mar 29, 2022

Makes for easier-to-read diffs.

Close #221.

Copy link
Owner

@mbrt mbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good! I left some comments but no deal breaker. Thanks for the contribution!

internal/engine/filter/filter.go Outdated Show resolved Hide resolved
internal/engine/filter/filter.go Outdated Show resolved Hide resolved
internal/engine/filter/filter.go Outdated Show resolved Hide resolved
internal/engine/filter/filter.go Outdated Show resolved Hide resolved
internal/engine/filter/filter.go Outdated Show resolved Hide resolved
testdata/valid/00-simple.diff Outdated Show resolved Hide resolved
testdata/valid/03-labels.diff Outdated Show resolved Hide resolved
testdata/valid/07-deleteall.diff Show resolved Hide resolved
internal/engine/filter/filter.go Outdated Show resolved Hide resolved
testdata/valid/07-deleteall.diff Show resolved Hide resolved
@lutzky lutzky force-pushed the master branch 2 times, most recently from 492cadc to 4b4f12f Compare April 2, 2022 21:40
@lutzky
Copy link
Contributor Author

lutzky commented Apr 2, 2022

Apologies for the additional pushes, some simplifications were staring me in the face very judgementally.

@mbrt
Copy link
Owner

mbrt commented Apr 3, 2022

Looks good, thanks! Please rebase to the latest master. I merged #240 in an attempt to fix the Go workflow.

Makes for easier-to-read diffs.

mbrt#221
@mbrt mbrt merged commit 1d7a570 into mbrt:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier-to-parse diff
2 participants