-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to ~/.config/gmailctl
for newly created config dirs
#393
Conversation
This is a minimal fix for mbrt#144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions!
There are also a bunch of references to the old directory in the main README.md. Could you update them?
I think the new behavior should also be explained in the gmailctl init --help
message. Something along the lines that the default config directory location moved from one location to the other.
Sorry for the back and forth, I missed these points in the earlier review. Thanks!
I thought about this a bit more and the problem with this PR is that it doesn't solve the problem for all platforms. I think the original issue is more about OSX and Windows, where polluting the home directory with dotfiles is not common. I'm afraid this just introduces one more variant without really tackling the underlying issue. |
I mean, that's fine if you'd prefer to match OS conventions more closely. How would you feel about using https://github.com/adrg/xdg to compute the config path? |
Using This should be explained decently in the docs, but I would agree with that change. |
This pull request is stale because it has been open for 30 days without activity. |
This is a minimal fix for #144