Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback ueberauth_oidcc version #1447

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Rollback ueberauth_oidcc version #1447

merged 1 commit into from
Jun 7, 2024

Conversation

ErinLMoore
Copy link
Contributor

Asana ticket

Somehow this version bump makes the links to reset your email and password stop working. Rolling back the changes for a quick fix. Verified working in dev-green.

(You can see the PR where we originally bumped the versions here)

@ErinLMoore ErinLMoore changed the title Rollback ueberauth version Rollback ueberauth_oidcc version Jun 7, 2024
Copy link
Collaborator

@arkadyan arkadyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ErinLMoore, if you haven't already, could you please create a ticket so that we can remember to figure out how to make this work correctly and get the upgrade back in in the future?

@ErinLMoore
Copy link
Contributor Author

👍

@ErinLMoore, if you haven't already, could you please create a ticket so that we can remember to figure out how to make this work correctly and get the upgrade back in in the future?

Already done, thanks for the quick approval!

@paulswartz
Copy link
Member

If reverting this fixes the issue, it's likely a bug with ueberauth_oidcc (my guess is an interaction with the new authorization_params_passthrough which wasn't fully tested). I'll look at that on my end.

@ErinLMoore ErinLMoore merged commit e5bd81a into main Jun 7, 2024
7 checks passed
@ErinLMoore ErinLMoore deleted the fix-links-elm branch June 7, 2024 14:21
@paulswartz
Copy link
Member

Looks like the issue was with Oidcc (but caused by me :( ): erlef/oidcc#354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants