-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shuttle shape page #978
Conversation
@bklebe This isn't ready for formal review. Adding you as reviewer for visibility re: #976 including the addition of the tailwind css v3 (comment here) |
92aad50
to
8efa0c3
Compare
cddd2c4
to
20dba1e
Compare
@@ -1,7 +1,8 @@ | |||
<.simple_form :let={f} for={@changeset} action={@action}> | |||
<.simple_form :let={f} for={@changeset} action={@action} multipart> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage of commit
|
@bklebe this scaffolding is ready for review now. I don't expect the details like the schema to be fully correct yet, it is to have something in place for tickets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad that I am reviewing this after I actually used it to get the S3 part working because I feel confident in saying this worked well and I ran into no issues while using the foundational pages here. 🚀
schema "shapes" do | ||
field :name, :string | ||
|
||
timestamps() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timestamps() | |
timestamps(type: :utc_datetime) |
and migration update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we had a few dependent PRs (#984 is branched off of this, this PR was branched off another), I moved this into a new PR.
4823396
to
f9e89ca
Compare
Coverage of commit
|
Coverage of commit
|
Summary of changes
Fulfills the first bullet point in https://app.asana.com/0/584764604969369/1207339672568992
This should unblock the S3 upload ticket.
Reviewer Checklist