Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shuttle shape page #978

Merged
merged 26 commits into from
Jun 13, 2024
Merged

feat: add shuttle shape page #978

merged 26 commits into from
Jun 13, 2024

Conversation

meagharty
Copy link
Collaborator

@meagharty meagharty commented Jun 5, 2024

Summary of changes

Fulfills the first bullet point in https://app.asana.com/0/584764604969369/1207339672568992

This should unblock the S3 upload ticket.

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@meagharty meagharty changed the title Meag/add shuttle shape page [Draft] feat: add shuttle shape page Jun 5, 2024
@meagharty meagharty requested a review from bklebe June 6, 2024 15:27
@meagharty
Copy link
Collaborator Author

@bklebe This isn't ready for formal review. Adding you as reviewer for visibility re: #976 including the addition of the tailwind css v3 (comment here)

@@ -1,7 +1,8 @@
<.simple_form :let={f} for={@changeset} action={@action}>
<.simple_form :let={f} for={@changeset} action={@action} multipart>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meagharty meagharty changed the title [Draft] feat: add shuttle shape page feat: add shuttle shape page Jun 7, 2024
@meagharty meagharty marked this pull request as ready for review June 7, 2024 15:06
Copy link

github-actions bot commented Jun 7, 2024

Coverage of commit 9de3398

Summary coverage rate:
  lines......: 80.6% (768 of 953 lines)
  functions..: 61.6% (564 of 916 functions)
  branches...: no data found

Files changed coverage rate:
                                                                     |Lines       |Functions  |Branches    
  Filename                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================
  lib/arrow/shuttle.ex                                               |87.5%      8|87.5%     8|    -      0
  lib/arrow/shuttle/shape.ex                                         | 100%      2|83.3%     6|    -      0
  lib/arrow_web/controllers/shape_controller.ex                      | 100%     23|92.3%    13|    -      0
  lib/arrow_web/controllers/shape_html.ex                            | 100%      1|20.0%     5|    -      0
  lib/arrow_web/router.ex                                            |95.0%     20|40.7%    81|    -      0
  test/support/conn_case.ex                                          | 100%     12| 100%     5|    -      0
  test/support/fixtures/shuttle_fixtures.ex                          | 100%      4| 100%     3|    -      0

Download coverage report

@meagharty
Copy link
Collaborator Author

@bklebe this scaffolding is ready for review now. I don't expect the details like the schema to be fully correct yet, it is to have something in place for tickets.

@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@mbta mbta deleted a comment from github-actions bot Jun 7, 2024
@fsaid90 fsaid90 requested a review from nlwstein June 11, 2024 14:11
Copy link
Contributor

@nlwstein nlwstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad that I am reviewing this after I actually used it to get the S3 part working because I feel confident in saying this worked well and I ran into no issues while using the foundational pages here. 🚀

schema "shapes" do
field :name, :string

timestamps()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timestamps()
timestamps(type: :utc_datetime)

and migration update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we had a few dependent PRs (#984 is branched off of this, this PR was branched off another), I moved this into a new PR.

@meagharty meagharty force-pushed the meag/add-phx7-core-components branch from 4823396 to f9e89ca Compare June 12, 2024 15:41
Base automatically changed from meag/add-phx7-core-components to master June 13, 2024 15:05
Copy link

Coverage of commit d607eaf

Summary coverage rate:
  lines......: 80.6% (768 of 953 lines)
  functions..: 61.6% (564 of 916 functions)
  branches...: no data found

Files changed coverage rate:
                                                                     |Lines       |Functions  |Branches    
  Filename                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================
  lib/arrow/shuttle.ex                                               |87.5%      8|87.5%     8|    -      0
  lib/arrow/shuttle/shape.ex                                         | 100%      2|83.3%     6|    -      0
  lib/arrow_web/controllers/shape_controller.ex                      | 100%     23|92.3%    13|    -      0
  lib/arrow_web/controllers/shape_html.ex                            | 100%      1|20.0%     5|    -      0
  lib/arrow_web/router.ex                                            |95.0%     20|40.7%    81|    -      0
  test/support/conn_case.ex                                          | 100%     12| 100%     5|    -      0
  test/support/fixtures/shuttle_fixtures.ex                          | 100%      4| 100%     3|    -      0

Download coverage report

Copy link

Coverage of commit d607eaf

Summary coverage rate:
  lines......: 80.6% (768 of 953 lines)
  functions..: 61.6% (564 of 916 functions)
  branches...: no data found

Files changed coverage rate:
                                                                     |Lines       |Functions  |Branches    
  Filename                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================
  lib/arrow/shuttle.ex                                               |87.5%      8|87.5%     8|    -      0
  lib/arrow/shuttle/shape.ex                                         | 100%      2|83.3%     6|    -      0
  lib/arrow_web/controllers/shape_controller.ex                      | 100%     23|92.3%    13|    -      0
  lib/arrow_web/controllers/shape_html.ex                            | 100%      1|20.0%     5|    -      0
  lib/arrow_web/router.ex                                            |95.0%     20|40.7%    81|    -      0
  test/support/conn_case.ex                                          | 100%     12| 100%     5|    -      0
  test/support/fixtures/shuttle_fixtures.ex                          | 100%      4| 100%     3|    -      0

Download coverage report

@meagharty meagharty merged commit 083a720 into master Jun 13, 2024
16 checks passed
@meagharty meagharty deleted the meag/add-shuttle-shape-page branch June 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants