Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily suppress terminal/reverse trip predictions for Red Line and Blue Line in Concentrate #277

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Temporarily suppress terminal/reverse trip predictions for Red Line and Blue Line in Concentrate #277

merged 6 commits into from
Apr 6, 2023

Conversation

bklebe
Copy link
Member

@bklebe bklebe commented Apr 6, 2023

Summary of changes

Asana Ticket: [extra] 🧠 Temporarily suppress terminal/reverse trip predictions for Red Line and Blue Line in Concentrate

Adds a new GroupFilter that removes uncertain StopTimeUpdates from a group that match a route_id and uncertainty value specified as a map in config.exs. Also updates config.exs to suppress Red and Blue line terminal and reverse predictions while we wait for schedules to recover.

@bklebe bklebe requested a review from paulswartz April 6, 2023 20:32
@bklebe
feat: remove terminal and reverse predictions on Red and Blue lines
ca51f3e 
This commit introduces a new GroupFilter,
RemoveUncertainStopTimeUpdates, which filters out StopTimeUpdates from
a group that match a specified route_id and uncertainty value
specified in config.exs.
@bklebe
fixup! feat: remove terminal and reverse predictions on Red and Blue …
1491089 
…lines
@bklebe bklebe force-pushed the bak-suppress-terminal-reverse branch from f8fb53a to 1491089 Compare April 6, 2023 20:44
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Coverage of commit 1491089

Summary coverage rate:
  lines......: 96.6% (1061 of 1098 lines)
  functions..: 79.6% (358 of 450 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/remove_uncertain_stop_time_updates.ex|71.4%      7|66.7%     3|    -      0

Download coverage report

@bklebe bklebe force-pushed the bak-suppress-terminal-reverse branch from a0a49bb to 5a04de4 Compare April 6, 2023 20:55
@bklebe bklebe temporarily deployed to dev April 6, 2023 20:55 — with GitHub Actions Inactive
@bklebe bklebe temporarily deployed to dev April 6, 2023 21:06 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Coverage of commit 0fc5161

Summary coverage rate:
  lines......: 96.6% (1062 of 1099 lines)
  functions..: 79.6% (358 of 450 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/remove_uncertain_stop_time_updates.ex|75.0%      8|66.7%     3|    -      0

Download coverage report

paulswartz
paulswartz approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 thanks!

@paulswartz paulswartz merged commit 43911f9 into master Apr 6, 2023
@paulswartz paulswartz deleted the bak-suppress-terminal-reverse branch April 6, 2023 23:07
@bklebe bklebe restored the bak-suppress-terminal-reverse branch April 19, 2023 15:14
@bklebe bklebe deleted the bak-suppress-terminal-reverse branch April 19, 2023 15:19
@nlwstein nlwstein mentioned this pull request Jun 30, 2023
Merged
@nlwstein nlwstein mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulswartz paulswartz paulswartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bklebe @paulswartz