Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Keolis realtime gtfs #282

Merged
merged 11 commits into from
Aug 24, 2023
Merged

feat: Keolis realtime gtfs #282

merged 11 commits into from
Aug 24, 2023

Conversation

Whoops
Copy link
Collaborator

@Whoops Whoops commented Jun 9, 2023 •
edited
Loading

Summary of changes

Asana Ticket: 🚆Keolis Feed Transition

Does 3 main things:

  1. Adds the Keolis GTFS enhanced feeds to the local configuration
  2. Makes the handling of on time statuses no longer case sensitive
  3. Overrides the boarding statuses provided by Keolis to match those in Commuter Rail Boarding

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Coverage of commit a9a70eb

Summary coverage rate:
  lines......: 94.9% (1185 of 1249 lines)
  functions..: 84.1% (380 of 452 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |92.3%     13|75.0%     4|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green June 9, 2023 21:08 — with GitHub Actions Inactive
@Whoops Whoops temporarily deployed to dev-green June 9, 2023 21:19 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Coverage of commit a4223b6

Summary coverage rate:
  lines......: 95.1% (1189 of 1250 lines)
  functions..: 84.3% (381 of 452 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green June 12, 2023 14:26 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 40cb30d

Summary coverage rate:
  lines......: 94.8% (1185 of 1250 lines)
  functions..: 84.1% (380 of 452 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green June 14, 2023 15:34 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 9f9d833

Summary coverage rate:
  lines......: 95.1% (1194 of 1256 lines)
  functions..: 84.2% (383 of 455 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0

Download coverage report

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Coverage of commit d187a18

Summary coverage rate:
  lines......: 94.7% (1190 of 1256 lines)
  functions..: 84.0% (382 of 455 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0

Download coverage report

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Coverage of commit 9f931f9

Summary coverage rate:
  lines......: 95.1% (1197 of 1259 lines)
  functions..: 84.2% (384 of 456 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green August 2, 2023 14:21 — with GitHub Actions Inactive
@Whoops Whoops temporarily deployed to dev-green August 2, 2023 20:49 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Coverage of commit 6e6eede

Summary coverage rate:
  lines......: 95.1% (1197 of 1259 lines)
  functions..: 84.2% (384 of 456 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.2%     71| 100%    16|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green August 3, 2023 13:58 — with GitHub Actions Inactive
@Whoops Whoops temporarily deployed to dev-green August 3, 2023 15:34 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Coverage of commit b4de009

Summary coverage rate:
  lines......: 95.1% (1199 of 1261 lines)
  functions..: 84.2% (384 of 456 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.3%     73| 100%    16|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green August 4, 2023 14:39 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Coverage of commit 655420d

Summary coverage rate:
  lines......: 95.0% (1201 of 1264 lines)
  functions..: 84.2% (385 of 457 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.3%     73| 100%    16|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green August 7, 2023 13:54 — with GitHub Actions Inactive
@Whoops Whoops temporarily deployed to dev-green August 7, 2023 18:44 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Coverage of commit 480e654

Summary coverage rate:
  lines......: 95.0% (1199 of 1262 lines)
  functions..: 84.2% (385 of 457 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.2%     71| 100%    16|    -      0

Download coverage report

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Coverage of commit a887bd7

Summary coverage rate:
  lines......: 95.0% (1202 of 1265 lines)
  functions..: 84.2% (385 of 457 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.3%     74| 100%    16|    -      0

Download coverage report

@Whoops Whoops temporarily deployed to dev-green August 17, 2023 15:04 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 0dac101

Summary coverage rate:
  lines......: 95.0% (1202 of 1265 lines)
  functions..: 84.3% (386 of 458 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.3%     74| 100%    17|    -      0

Download coverage report

@Whoops Whoops marked this pull request as ready for review August 21, 2023 19:53
@Whoops Whoops requested a review from a team August 21, 2023 19:54
@Whoops Whoops temporarily deployed to dev-green August 21, 2023 20:11 — with GitHub Actions Inactive
paulswartz
paulswartz requested changes Aug 21, 2023
View reviewed changes
config/config.exs Outdated Show resolved Hide resolved
lib/concentrate/group_filter/scheduled_stop_times.ex Show resolved Hide resolved
lib/concentrate/parser/gtfs_realtime_enhanced.ex Outdated Show resolved Hide resolved
@Whoops Whoops temporarily deployed to dev-green August 22, 2023 16:44 — with GitHub Actions Inactive
@Whoops Whoops temporarily deployed to dev-green August 23, 2023 18:20 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 8e2fb79

Summary coverage rate:
  lines......: 95.0% (1202 of 1265 lines)
  functions..: 84.3% (386 of 458 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.3%     74| 100%    17|    -      0

Download coverage report

@Whoops Whoops requested a review from paulswartz August 23, 2023 18:25
@Whoops Whoops temporarily deployed to dev-green August 23, 2023 18:57 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit d0f6bf4

Summary coverage rate:
  lines......: 95.2% (1211 of 1272 lines)
  functions..: 84.6% (390 of 461 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/group_filter/scheduled_stop_times.ex              |85.7%     14|75.0%     4|    -      0
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.3%     74| 100%    17|    -      0

Download coverage report

@Whoops Whoops merged commit 750647b into master Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bklebe bklebe bklebe left review comments

@paulswartz paulswartz paulswartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Whoops @paulswartz @bklebe