Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow integer vehicle IDs #305

Closed
wants to merge 1 commit into from
Closed

feat: allow integer vehicle IDs #305

wants to merge 1 commit into from

Conversation

bklebe
Copy link
Member

@bklebe bklebe commented Sep 15, 2023

Summary of changes

Asana Ticket: allow integer vehicle IDs in concentrate in case they get passed through

Logs a warning if an integer vehicle ID is encountered and stringifies it with Integer.to_string/1.

@bklebe bklebe requested review from a team and Whoops September 15, 2023 23:05
@github-actions
Copy link

Coverage of commit a95dbc6

Summary coverage rate:
  lines......: 94.5% (1243 of 1316 lines)
  functions..: 83.1% (404 of 486 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/parser/gtfs_realtime_enhanced.ex                  |97.6%     82| 100%    17|    -      0

Download coverage report

@bklebe bklebe temporarily deployed to dev-green September 15, 2023 23:15 — with GitHub Actions Inactive
Copy link
Member

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should this also handle the id field in the VehiclePosition struct?

@bklebe bklebe closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants