Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log when VehiclePositions move backwards in time #318

Merged
merged 3 commits into from
Oct 23, 2023
Merged

feat: log when VehiclePositions move backwards in time #318

merged 3 commits into from
Oct 23, 2023

Conversation

paulswartz
Copy link
Member

Summary of changes

Asana Ticket: Green Line trains going backwards in time

Logs when vehicles have a timestamp earlier than the current timestamp.

@paulswartz paulswartz requested review from a team and dks-mbta October 20, 2023 13:28
@github-actions
Copy link

Coverage of commit 7fb8734

Summary coverage rate:
  lines......: 93.3% (1378 of 1477 lines)
  functions..: 83.0% (445 of 536 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/reporter/vehicle_time_travel.ex                   |92.3%     13| 100%     4|    -      0
  lib/concentrate/source_reporter/basic.ex                          | 100%      5| 100%     2|    -      0

Download coverage report

@paulswartz paulswartz temporarily deployed to dev-green October 20, 2023 18:34 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit c6c6a3d

Summary coverage rate:
  lines......: 93.3% (1388 of 1488 lines)
  functions..: 83.0% (445 of 536 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/merge_filter.ex                                   |97.6%     82|82.4%    17|    -      0
  lib/concentrate/reporter/vehicle_time_travel.ex                   |92.3%     13| 100%     4|    -      0
  lib/concentrate/source_reporter/basic.ex                          | 100%      5| 100%     2|    -      0

Download coverage report

@paulswartz paulswartz temporarily deployed to dev-green October 20, 2023 18:55 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 04dace3

Summary coverage rate:
  lines......: 93.3% (1388 of 1488 lines)
  functions..: 83.0% (445 of 536 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/merge_filter.ex                                   |97.6%     82|82.4%    17|    -      0
  lib/concentrate/reporter/vehicle_time_travel.ex                   |92.3%     13| 100%     4|    -      0
  lib/concentrate/source_reporter/basic.ex                          | 100%      5| 100%     2|    -      0

Download coverage report

@paulswartz paulswartz temporarily deployed to dev-green October 20, 2023 19:12 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 65cf6c1

Summary coverage rate:
  lines......: 93.3% (1388 of 1488 lines)
  functions..: 83.0% (445 of 536 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/merge_filter.ex                                   |97.6%     82|82.4%    17|    -      0
  lib/concentrate/reporter/vehicle_time_travel.ex                   |92.3%     13| 100%     4|    -      0
  lib/concentrate/source_reporter/basic.ex                          | 100%      5| 100%     2|    -      0

Download coverage report

@paulswartz paulswartz merged commit 68a9fb6 into master Oct 23, 2023
9 checks passed
@github-actions
Copy link

Coverage of commit 7fb8734

Summary coverage rate:
  lines......: 93.3% (1385 of 1485 lines)
  functions..: 83.0% (445 of 536 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/reporter/vehicle_time_travel.ex                   |92.3%     13| 100%     4|    -      0
  lib/concentrate/source_reporter/basic.ex                          | 100%      5| 100%     2|    -      0

Download coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dks-mbta dks-mbta dks-mbta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paulswartz @dks-mbta