Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FileTap): remove configuration #322

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix(FileTap): remove configuration #322

merged 2 commits into from
Oct 25, 2023

Conversation

paulswartz
Copy link
Member

@paulswartz paulswartz commented Oct 25, 2023

Asana Ticket: https://app.asana.com/0/584764604969369/1205748776837980/f

Since we're only running the FileTap server when it's enabled, we don't need additional configuration in the GenServer. This is on my for not more effectively testing it locally before putting up the various pull requests. I have tested this locally and it works.

@paulswartz paulswartz temporarily deployed to dev-green October 25, 2023 13:32 — with GitHub Actions Inactive
@paulswartz paulswartz requested review from a team and Whoops October 25, 2023 13:38
Since we're only running `FileTap` if it's enabled, we don't need to
pass it in as a configuration.
Compiles correctly on macOS Sonoma.
@github-actions
Copy link

Coverage of commit 2b96842

Summary coverage rate:
  lines......: 93.3% (1382 of 1482 lines)
  functions..: 83.0% (445 of 536 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/producer/file_tap.ex                              |95.5%     22|90.0%    10|    -      0
  lib/concentrate/supervisor/pipeline.ex                            |97.3%     37| 100%    10|    -      0

Download coverage report

@paulswartz paulswartz merged commit 3765776 into master Oct 25, 2023
3 checks passed
@paulswartz paulswartz deleted the ps-sinks branch October 25, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants