fix: don't include non-revenue trips in feeds #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
paulswartz
reviewed
Nov 6, 2023
Whoops
force-pushed
the
wh-non-revenue-trips
branch
from
2db12cf
to
1668a38
Compare
Coverage of commit
|
Whoops
force-pushed
the
wh-non-revenue-trips
branch
from
1668a38
to
4d04f32
Compare
Coverage of commit
|
Whoops
force-pushed
the
wh-non-revenue-trips
branch
from
4d04f32
to
ff57584
Compare
|
This has been updated to use the (soon to be) newly added revenue field in RTR rather than filtering on |
Coverage of commit
|
paulswartz
reviewed
Nov 27, 2023
| %{route_pattern_id: TripDescriptor.route_pattern_id(update)} | ||
| %{ | ||
| route_pattern_id: TripDescriptor.route_pattern_id(update), | ||
| revenue: TripDescriptor.revenue(update) |
There was a problem hiding this comment.
suggestion: given that true is the default, what about only including it when the value is false?
There was a problem hiding this comment.
If you feel strongly about it, I can. My main hesitation is that in nil ~ falsey languages, the naive interpretation is the opposite of what we actually mean. I'd tend to argue there shouldn't be a default, but maintaining current behavior on existing feeds kind of forces our hand there.
There was a problem hiding this comment.
As you note, existing clients which care about this value will need to treat a missing value as true (as it was true for all trips before). But I don't think it needs to block the PR.
| @@ -19,7 +21,7 @@ defmodule Concentrate.Encoder.VehiclePositionsEnhanced do | |||
| end | |||
|
|
|||
| def build_entity({%TripDescriptor{} = td, vps, _stus}) do | |||
| trip = trip_descriptor(td) | |||
| trip = trip_descriptor(td) |> Map.put("revenue", TripDescriptor.revenue(td)) | |||
There was a problem hiding this comment.
Suggested change
| trip = trip_descriptor(td) |> Map.put("revenue", TripDescriptor.revenue(td)) | |
| trip = td | |
| |> trip_descriptor() | |
| |> Map.put("revenue", TripDescriptor.revenue(td)) |
There was a problem hiding this comment.
We might want to consider turning on Credo's PipeChainStart check. It's explicitly off at the moment.
Whoops
force-pushed
the
wh-non-revenue-trips
branch
from
ff57584
to
d3ef98e
Compare
Coverage of commit
|
paulswartz
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🧠 Concentrate suppresses non-revenue trips until December 7
Note: We will shortly want to start exposing non-revenue trips in the enhanced feed. This implementation is chosen to make that update trivial.