🧠 Ingest OIO trigger and suppress relevant predictions #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
nlwstein
approved these changes
May 10, 2024
| @@ -74,8 +77,8 @@ config :concentrate, | |||
| Concentrate.GroupFilter.VehicleStopMatch, | |||
| Concentrate.GroupFilter.SkippedStopOnAddedTrip, | |||
| Concentrate.GroupFilter.TripDescriptorTimestamp, | |||
| Concentrate.GroupFilter.UncertaintyValue | |||
| # Concentrate.GroupFilter.SuppressStopTimeUpdate Enable once fully implemented | |||
There was a problem hiding this comment.
nit: I'm ambivalent personally, but there seems to be a preference here towards avoiding commented code. Maybe this should just be whacked, and then added when it's actually in use.
There was a problem hiding this comment.
this was actually already merged in and is being updated in this PR
| Supervisor.start_link( | ||
| [ | ||
| { | ||
| Concentrate.producer_for_url(config[:url]), |
There was a problem hiding this comment.
Would it be worth adding a test to either confirm that it actually starts pulling this file?
There was a problem hiding this comment.
sure thing, focusing on getting the terraform changes in so that I can put this on dev for more thorough testing but can add a test for this
Coverage of commit
|
bfauble
commented
May 13, 2024
| end) | ||
| end | ||
|
|
||
| defp parse_response(body, state) do |
There was a problem hiding this comment.
@nlwstein this was added so that the events list wasn't empty if the new state should be empty. otherwise the GenStage does not actually pass along the empty array as a message.
Coverage of commit
|
nlwstein
approved these changes
May 14, 2024
Coverage of commit
|
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Fetch Config