Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elixir] bug: allow empty datasets to be passed into dmap feed update #57

Merged

Conversation

grejdi-mbta
Copy link
Collaborator

When there is no update to the feed, the worker will pass an empty list of datasets to the update function of DMAP feed. This PR handles this case, so max_by/3 doesn't error out.

@github-actions
Copy link

Coverage of commit 56ab37b

Summary coverage rate:
  lines......: 90.3% (380 of 421 lines)
  functions..: 70.1% (157 of 224 functions)
  branches...: no data found

Files changed coverage rate:
                                                           |Lines       |Functions  |Branches    
  Filename                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================
  lib/ex_cubic_ingestion/schema/cubic_dmap_feed.ex         | 100%     10| 100%    11|    -      0

Download coverage report

Copy link
Member

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@grejdi-mbta grejdi-mbta merged commit 102ee2e into main Jun 14, 2022
@grejdi-mbta grejdi-mbta deleted the gg-bug-handle-empty-datasets-when-updating-dmap-feed-info branch June 14, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants