Upgrade Keycloak to 23.0.3 and enable token exchange feature #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jurakp
commented
Jan 16, 2024
jurakp
commented
- Upgrade Keycloak to 23.0.3
- Enable preview feature Token Exchange
added 2 commits
January 16, 2024 14:12
Removed all username validation errors
paulswartz
reviewed
Jan 16, 2024
| @@ -32,7 +32,7 @@ RUN ["/bin/bash", "-c", "cp -Rv $INSTALL_FOLDER/templates/* $KC_FOLDER/themes/"] | |||
| # add integsoft version of keycloak jars | |||
| RUN ["/bin/bash", "-c", "cp -Rv $INSTALL_FOLDER/keycloak-modules/* $KC_FOLDER/lib/lib/main"] | |||
|
|
|||
| RUN /opt/keycloak/bin/kc.sh build --spi-email-sender-provider=aws-ses --spi-email-sender-provider-aws-ses-enabled=true --spi-email-sender-provider-aws-ses-region=$AWS_REGION | |||
| RUN /opt/keycloak/bin/kc.sh build --spi-email-sender-provider=aws-ses --spi-email-sender-provider-aws-ses-enabled=true --spi-email-sender-provider-aws-ses-region=$AWS_REGION --features="token-exchange" | |||
There was a problem hiding this comment.
question: should we also be enabling the multi-site feature to pick up the new health check? https://www.keycloak.org/docs/latest/release_notes/index.html#non-blocking-health-check-for-load-balancers
There was a problem hiding this comment.
This is not needed. Load balancing is done in ECS. And the health check we have already in place is good enough. For more information look at the infrastructure project:
https://github.com/mbta/terraform-keycloak-sso/blob/d2686452bd3f0a72c803d900e839f6fe3b0a3de3/loadbalancer.tf#L64
paulswartz
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.