Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added locator trait. Added extra defaults for attributesForTrait_Fan… #63

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Conversation

wir3z
Copy link
Contributor

@wir3z wir3z commented Apr 18, 2021

Finished the locator trait.

Copy link
Owner

@mbudnek mbudnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution. I noticed just a couple of minor issues, mainly around MFA (not that anyone is likely to set a pin code for this trait, but good to be consistent).

google-home-community.groovy Outdated Show resolved Hide resolved
google-home-community.groovy Outdated Show resolved Hide resolved
packageManifest.json Outdated Show resolved Hide resolved
@wir3z
Copy link
Contributor Author

wir3z commented Apr 21, 2021

Updated with the necessary changes.

@wir3z
Copy link
Contributor Author

wir3z commented Apr 21, 2021

Added the latest Google Trait

@mbudnek mbudnek merged commit cfe69ec into mbudnek:master Apr 21, 2021
@mbudnek
Copy link
Owner

mbudnek commented Apr 21, 2021

Merged. Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants