[v2] Allow immediate response #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow immediate responses to google - does not wait for device to enter new state.
Update immediateResponse to require less checks and be easier to remove when response handler is updated with intent response instead of status response.
…abled. Return PENDING instead of SUCCESS if device state does not reach desired value within timeout. Change timeout to 1000 ms when immediate response enabled.
Closed
|
BTW, I tested this with switches, dimmers, locks, fans, and shades. I have a few other device types I can test but the basics seem to work. |
mbudnek
reviewed
May 7, 2021
There was a problem hiding this comment.
Thanks for the contribution! These changes look great. I don't think the immediateReponse setting is necessary, but if you do want to keep it can you add something to README.md describing what it does? Also, can you please update the version number in packageManifest.json to 0.30.0?
…anifest.json to 0.30.0
|
Looks great. Thanks again for the contribution! |
|
Rock on! |
mbudnek
added a commit
that referenced
this pull request
May 8, 2021
The Toggles trait is unique in that its command executor method calls the executeCommand_OnOff method to do its actual work. #69 recently changed the return value of the command executors but missed this one case. This restores Toggles to full functionality.
mbudnek
added a commit
that referenced
this pull request
May 8, 2021
The Toggles trait is unique in that its command executor method calls the executeCommand_OnOff method to do its actual work. #69 recently changed the return value of the command executors but missed this one case. This restores Toggles to full functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update on top of #42 and includes the commits from that PR in this one.
In this PR, I update each execute handler to return both the attributes to await and the new assumed states of the device.
I also changed the logic to keep the poll for the attributes to await when immediate response is enabled, but shorten the poll from 5000 ms to 1000 ms.
For both immediate response and the previous behavior, we now return
PENDINGinstead ofSUCCESSwhen the device attributes have not yet all been reached.