Fix path to require jQuery UI in assets pipeline. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent versions of Rails, the right path is 'jquery-ui/widgets/<widget>'. See https://github.com/jquery-ui-rails/jquery-ui-rails#require-specific-modules for details.
1 similar comment
|
Any concerns with merging this? |
|
Friendly ping 😊 |
|
@mbulat any chance you could take a look at this PR anytime soon? |
|
@mbulat ping |
|
+1 |
|
@mbulat can you merge this PR or give me write access so I can merge it? 😊 |
dennyabraham
added a commit
to dennyabraham/tyche
that referenced
this pull request
Jul 9, 2019
|
Fixed in 0eebb2f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent versions of Rails, the right path is
jquery-ui/widgets/<widget>. See https://github.com/jquery-ui-rails/jquery-ui-rails#require-specific-modules for details.I also added jQuery and jQuery UI to the Gemfile as explicit dependencies for this gem (I got a load error when I tried to use this gem since I didn't have those gems in my app's Gemfile).